Frontend Tech + >> MAMEUI & IV/Play
View all threads Index   Flat Mode Flat  

Zaghadka
MAME Groupie
Reged: 04/26/11
Posts: 114
Send PM
Fixed minor error with tag187 - can't commit to git
06/28/17 02:14 PM


As usual, the newest compilation tools treat indentation errors as fatal.

Error message:


Code:

$ make -j5 OSD=messui
GCC 6.3.0 detected
Compiling src/osd/winui/newui.cpp...
Compiling src/osd/winui/screenshot.cpp...
Compiling src/osd/winui/softwarelist.cpp...
Compiling src/osd/winui/softwarepicker.cpp...
../../../../../src/osd/winui/newui.cpp: In function 'void prepare_menus(HWND)':
../../../../../src/osd/winui/newui.cpp:2798:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
if (!img.user_loadable())
^~
../../../../../src/osd/winui/newui.cpp:2801:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
new_item = ID_DEVICE_0 + (cnt * DEVOPTION_MAX);
^~~~~~~~
Compiling src/osd/winui/splitters.cpp...
Compiling src/osd/winui/swconfig.cpp...
Compiling src/osd/winui/tabview.cpp...
cc1plus.exe: all warnings being treated as errors
make[2]: *** [osd_messui.make:1666: ../../../../mingw-gcc/obj/x64/Release/osd_messui/src/osd/winui/newui.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:19: osd_messui] Error 2
make: *** [makefile:994: windows_x64] Error 2



Basically, to fix you edit line 2801 of newui.cpp, in the IF statement that starts at ln. 2798. Remove one tab from the line "new_item = ID_DEVICE_0 + (cnt * DEVOPTION_MAX);" and it compiles.

This happened before and it actually tipped off a minor error in the code, so have a look and see if more changes are needed. Otherwise, someone who has access might commit this to the source tree.

Thanks.

Zag







Entire thread
Subject Posted by Posted on
* Fixed minor error with tag187 - can't commit to git Zaghadka 06/28/17 02:14 PM

Extra information Permissions
Moderator:  John IV 
0 registered and 11 anonymous users are browsing this forum.
You cannot start new topics
You cannot reply to topics
HTML is enabled
UBBCode is enabled
Thread views: 790